Implemented find_opt in Map.S interface #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue : #940
This Pull request adds a find_opt function to the Map.S interface. It appears that there was already a find_option implemented in Map.Concrete so I just used that. Another implementation was needed in BatSplay.ml so I added one. Also note that a function with the same type is implemented in Map.S.Exceptionless. Maybe we should do some factorization, but for now I changed the code as little as possible.
There was a discussion on the issue on which syntax should be used (about whether or not use the match... exception syntax). I'm still not clear on the subject, so I'm waiting for your comments.