Glob: Double asterisk match including slash #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double asterisk ('**') matches slash characters when `pathname` is
true.
It is set by default.
We must match each components and leading periods individually.
|
Seems good. Could you add a CHANGES entry? |
|
Added. |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Aug 25, 2021
CHANGES: * Add the `[:alpha:]` character class in `Re.Perl` (ocaml/ocaml-re#169) * Double asterisk (`**`) in `Re.Glob` (ocaml/ocaml-re#172) Like `*` but also match `/` characters when `pathname` is set. * Double asterisk should match 0 or more directories unless in trailing position. (ocaml/ocaml-re#192, fixes ocaml/ocaml-re#185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds support for double asterisks (
**) toGlob.It is like
*but also matches/characters, even whenpathnameis set.For example,
foo/**will match bothfoo/barandfoo/bar/baz.The
periodflag still work,foo/**won't matchfoo/.barbutfoo/.**will.Related to issue #171
This is useful in OCamlformat, where the matching is done on the whole path: ocaml-ppx/ocamlformat#1234