Glob: add ~backslash_escapes to control handling of backslashes #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 9, 2021
CHANGES: * Glob: add optional argument `?backslash_escapes` to control interpretation of backslashes (useful under Windows) (ocaml/ocaml-re#197, ocaml/ocaml-re#198) * Restore accidentally deleted `*_seq` deprecated aliases.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #197, which had only a partial fix for the handling of backslashes in the
Globmodule. In this PR, we add a new optional argument toGlob.glob, namely~backslash_escapes. Whentrue(the default), behaviour is unchanged: backslashes escape the following character. Whenfalse, backslashes are taken to be equivalent to forward slashes, which is useful when globbing Windows paths.