-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naive approach at functorizing Re #20
Conversation
I agree it would be great if other string representation were supported. I think only the It does not make much sense to abstract over characters. The library assumes at the moment that there are 256 of them, and it cannot be easily extended to support larger character sets. The library uses strings internally as compact arrays. We really want to use Ocaml strings for that, and not another string variant. |
The library is quite old. I don't think we had packed modules when it was written. How would they help in organizing stuff? |
they will be outside of functor
To expose the re functor we must write a signature for it
they now reside in Re_intf.S
it was just a type synonym for Re.t that wasn't exposed anywhere
it could be useful for other who would like to instantiate the Re.Make functor
it now resides in Re_intf
@vouillon Whoops, I totally forgot about this PR. I've revived it and got rid of functorizing over Char. Will read it over your other suggestions as well. My comment about packing meant that it would be nicer to export a single top level |
It would be really great if Re worked on bigstrings, substrings, ropes, etc. This is my naive attempt at exposing a functor for this to be possible.
Some notes