Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement and splitting functions: fixes and improvement #233

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

vouillon
Copy link
Member

@vouillon vouillon commented Dec 4, 2023

  • Add a Re.split_delim function
  • Fix handling of empty matches in replacement and splitting functions

Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgrinberg rgrinberg merged commit 5a9c9bf into master Mar 25, 2024
2 checks passed
@vouillon vouillon deleted the empty-matches branch March 25, 2024 23:36
shonfeder pushed a commit to ocaml/opam-repository that referenced this pull request Sep 3, 2024
CHANGES:

* Add `Re.split_delim` (ocaml/ocaml-re#233)
* Fix handling of empty matches in splitting and substitution functions (ocaml/ocaml-re#233)
* Add support for character classes in `Re.Posix` (ocaml/ocaml-re#263)
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
CHANGES:

* Add `Re.split_delim` (ocaml/ocaml-re#233)
* Fix handling of empty matches in splitting and substitution functions (ocaml/ocaml-re#233)
* Add support for character classes in `Re.Posix` (ocaml/ocaml-re#263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants