fix: cache this.commandsDir (#891)

* fix: cache this.comnmandsDir * test: ignore-scripts for integration tests
oclif · Nov 30, 2023 · 7b217a4 · 7b217a4
1 parent fcbcb32
commit 7b217a4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/config/plugin.ts b/src/config/plugin.ts
@@ -298,6 +298,7 @@ export class Plugin implements IPlugin {
   }
 
   private async getCommandsDir(): Promise<string | undefined> {
+    if (this.commandsDir) return this.commandsDir
     this.commandsDir = await tsPath(this.root, this.pjson.oclif.commands, this)
     return this.commandsDir
   }

diff --git a/test/integration/sf.e2e.ts b/test/integration/sf.e2e.ts
@@ -3,8 +3,7 @@ import {arch} from 'node:os'
 
 import {Executor, setup} from './util'
 
-import StripAnsi = require('strip-ansi')
-const stripAnsi: typeof StripAnsi = require('strip-ansi')
+const stripAnsi = require('strip-ansi')
 
 const chalk = require('chalk')
 chalk.level = 0

diff --git a/test/integration/util.ts b/test/integration/util.ts
@@ -186,9 +186,12 @@ export async function setup(testFile: string, options: SetupOptions): Promise<Ex
   executor.debug(`${bin}_CONFIG_DIR:`, process.env[`${bin}_CONFIG_DIR`])
   executor.debug(`${bin}_CACHE_DIR:`, process.env[`${bin}_CACHE_DIR`])
 
-  const yarnInstallRes = await executor.executeInTestDir('yarn install --force --network-timeout 600000', {
-    silent: false,
-  })
+  const yarnInstallRes = await executor.executeInTestDir(
+    'yarn install --force --network-timeout 600000 --ignore-scripts',
+    {
+      silent: false,
+    },
+  )
   if (yarnInstallRes.code !== 0) {
     console.error(yarnInstallRes?.error)
     throw new Error('Failed to run `yarn install --force`')