Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add refresh-cache hook #753

Merged
merged 1 commit into from
Aug 1, 2024
Merged

feat: add refresh-cache hook #753

merged 1 commit into from
Aug 1, 2024

Conversation

cristiand391
Copy link
Member

@cristiand391 cristiand391 commented Jul 30, 2024

DEPENDS ON: oclif/plugin-plugins#932

This PR adds a new refresh-cache hook that runs autocomplete create to regenerate autocomplete functions after installing or uninstalling plugins.

QA

  1. checkout this PR and sf plugins link it
  2. checkout this PR: feat: add plugins:post* hooks plugin-plugins#932 and sf plugins link it
  3. enable completion: sf autocomplete and follow instructions
  4. type sf org a<TAB>, see it doesn't suggest org api
  5. install new plugin: sf plugins install @cristiand391/sf-plugin-api
  6. open a new terminal pane (for zsh to source completion again) and repeat step 4, it should suggest org api options
  7. uninstall plugin: sf plugins uninstall @cristiand391/sf-plugin-api
  8. repeat step 6, shouldn't see org api completion.

@W-12465784@

@cristiand391 cristiand391 marked this pull request as ready for review July 30, 2024 20:14
@mdonnalley
Copy link
Contributor

QA

Followed steps in description

🟢 installing new plugin refreshes autocomplete
🟢 uninstalling new plugin refreshes autocomplete

@mdonnalley mdonnalley merged commit 3b928cd into main Aug 1, 2024
12 checks passed
@mdonnalley mdonnalley deleted the cd/hooks branch August 1, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants