GLFW: The ctrl or shift key are not detected in secondary viewports

[aiekick]

Hello,

Version/Branch of Dear ImGui:

Version: 1.89.4
Branch: viewport/docking_

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_Glfw.cpp + imgui_impl_Opengl.cpp
Compiler: Msvc
Operating System: Win10 x64

My Issue/Question:

In my lib ImGuiFileDialog, i have implemented a multi selection for select many files at same time.
in main viewport all is working as expected. but when the dialog is outside so becoming a second viewport,
the Ctrl and shift keys are not catched.

Screenshots/Video

After some search i found a fix, so i decided to share it.
btw im not sure if there is not a better and easy fix, or maybe is just a settings im not aware of it :)

in imgui_impl_glfw.cpp
i see than the function ImGui_ImplGlfw_UpdateKeyModifiers is not called for each windows, but just for the main viewport if i understood well.

so i modified it like that :

and called it like before with the current windows as params in the function ImGui_ImplGlfw_KeyCallback

and the result is :

i have not created a pull request because its a very small fix and maybe im wrong, but if you want i can.

Kind Regards

[ocornut]

Ouch, this was indeed broken by 1f6e62a (#6034) for multi-viewports It's a shame we don't have a better way to formally test backends
Will push your fix now.

[ocornut]

Fixed with 91577c7
I attributed you the commit
Thanks a lot !

[aiekick]

Thank you too 😀