-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GetGlyphRangesJapanese and Add GetGlyphRangesJoyoKanji #1650
Conversation
Thank you. If your project has known text, I think you can use If your project requires display of chat or user name, even with 8000+ ideogram it might be problematic? |
PS: Also, could you provide your data source for the 2136 and Joyo lists? |
the GetGlyphRangesChinese is too many words that I never know, but I need common words in my UI. Also I think it may not be important in common rules if all user known english :) Joyo Kanji 2136 Source : http://x0213.org/joyo-kanji-code/index.html Thank you |
Hello @metora, I believe #3627 now has superseded this. Neither solution is perfect but it the adopted ranges used by #3627 appears to be a general good solution in the meantime. I however noticed that your PR also adds the https://en.wikipedia.org/wiki/Bopomofo ranges:
Can you clarify, if you remember, why this was added to your JoyoKanji function? |
Closing this, but if you have an answer about the Bopomofo range it may be useful to know. |
I Updated GetGlyphRangesJapanese to Kanji Version 2010.
Then I Added GetGlyphRangesJoyoKanji, It mixed regular Chineses of GB2312 / Big5 / Shift-JIS,
about 8000+ ideograms only.