Fix extra 0.5f pixel offset #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults to 0.0f, which is correct for d3d10+ and ogl
Defaults to 0.0f, which is correct for d3d10+ and ogl
Defaults to 0.0f, which is correct for d3d10+ and ogl
|
Thanks, I will integrate a similar change but I think the offset should be applied to UV coordinates in the ImBitmapFont::RenderText function? |
|
Hello, I have merged in a change based on your patch. The field has been moved out of the Style structure into the IO structure and applies to UV coordinates (so the 0.0/0.5 values are backward). Sorry I am not sure how to treat a pull request with changes, this is the first pull request I get and I am new to Git :) |
ocornut
added a commit
that referenced
this pull request
Aug 20, 2016
…ation of non-integer mouse pos doesn't lead to undesirable movement (#3
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the text have the right side of each char cut off in opengl. Sorry for the messy commit structure ( new to github ), but the idea is simple, add a setting to imgui::imguistyle that has the offset. default to 0.0f, and change it to 0.5f in <= d3d9, leave 0.0f for ogl & d3d10+.