Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with InputTextMultiline/Password Flag issue #3427 #3428

Closed
wants to merge 2 commits into from
Closed

Fixed issue with InputTextMultiline/Password Flag issue #3427 #3428

wants to merge 2 commits into from

Conversation

hoffstadt
Copy link
Contributor

@hoffstadt hoffstadt commented Aug 24, 2020

Simple fix for an issue when using InputTextMultiline with the "ImGuiInputTextFlags_Password".

Simple fix for an issue when using InputTextMultiline with the "ImGuiInputTextFlags_Password".
@ocornut
Copy link
Owner

ocornut commented Aug 24, 2020

I believe this will fail/assert on non-password multiline fields.

@hoffstadt
Copy link
Contributor Author

hoffstadt commented Aug 24, 2020

Wow. Sorry about that. Dumb mistake. I updated it! Didn't mean to waste your time.

@hoffstadt
Copy link
Contributor Author

This should be good to go now. Please let know know if I missed anything else trivial. Ha

@ocornut
Copy link
Owner

ocornut commented Aug 25, 2020

Hello, thanks for reporting this. I didn't pick your commit as-is because it was unnecessarily complex and didn't follow the coding style, but applied an equivalent fix in 32be6c0. Thanks again!

@ocornut ocornut closed this Aug 25, 2020
@hoffstadt hoffstadt deleted the patch-1 branch August 25, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants