Added OpenGL3 example for SDL2 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pliced the GLFW OpenGL examples on top of the SDL example to create an option that works for me. Could be useful for others.
|
Thanks! could you clarify what wouldn't work with the GL2 code? |
|
I'm still new to openGL so this might be anecdotal evidence. When I had nothing else in my project apart from the IMGUI and SDL2 code, it would render fine. As soon as I started adding OGL3.3 rendering code into my program the gui disappeared. If I remember correctly OpenGL 3 onwards depreciated lots of OpenGL 2 rendering stuff, so the old 2-based code wouldn't render in a more modern context. |
ocornut
added a commit
that referenced
this pull request
Nov 16, 2015
ocornut
added a commit
that referenced
this pull request
Nov 16, 2015
|
Thanks, I have now merged this & done a few fixes to match the existing GL3 example code. |
|
Cool, happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous SDL implementation didn't work for me once I started using modern SDL code (it worked if I ripped out all my rendering code).
Spliced the GLFW OpenGL examples on top of the SDL example to create an option that works for me, could be useful for others.