Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert to ImGui_ImplGlfw_DestroyWindow #4666

Closed
wants to merge 1 commit into from
Closed

Add assert to ImGui_ImplGlfw_DestroyWindow #4666

wants to merge 1 commit into from

Conversation

AMS21
Copy link

@AMS21 AMS21 commented Oct 21, 2021

As dicussed in PR #4656

@ocornut
Copy link
Owner

ocornut commented Nov 2, 2021

Hello,
I don't think this is necessary anymore, as with bac748f this assert won't trigger.
#4656 (comment)

If we wanted that form of documentation it should be done in _Shutdown() and be done consistently for all back-ends.

Right now I am tempted to say we can wait and assume that shutdown is now possible in any order, further reports may help sturdy that.

@ocornut ocornut closed this Nov 2, 2021
@AMS21 AMS21 deleted the glfw_destroy_window_assert branch November 3, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants