Update comments in ImFontAtlas::GetGlyphRangesJapanese #6066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I would like to update comments in
ImFontAtlas::GetGlyphRangesJapanese
, which I wrote in 2020.What this PR do
ImFontAtlas::GetGlyphRangesJapanese
to remove old information source and replace it to new ones.GetGlyphRangesJapanese
.Details
I noticed the character database and its API ( mojikiban.ipa.go.jp/mji/ ) I used for updating
ImFontAtlas::GetGlyphRangesJapanese
in 2020 are no longer available. So I decided toGetGlyphRangesJapanese
with the new data sourceso that we don't have to depend on the unavailable database.
And now it's done. My repository https://github.com/vaiorabbit/everyday_use_kanji contains lists of Joyo ("for regular use") characters and Jinmeiyo ("for personal name") characters made from new sources:
To prepare these lists I used resources provided by the Agency for Cultural Affairs and the Ministry of Justice of Japan, which are available under CC-BY 4.0. For more details, please see everyday_use_kanji/LICENSE.
After that I regenerated the actual code of
ImFontAtlas::GetGlyphRangesJapanese
. We can say the changes made in this PR have resulted from copying and pasting this code.Please note that there's no difference made in the offset table (
static const short accumulative_offsets_from_0x4E00
) even if we run the updater script, because there's also no difference between characters we can get from new source I prepared and old ones from unavailable old database. As a result, the changes in this PR occurred only on the comments section.