Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan : Create a custom pipeline for viewports #7398

Closed
wants to merge 3 commits into from

Conversation

RahulVadhyar
Copy link

@RahulVadhyar RahulVadhyar commented Mar 13, 2024

As described in #6325, sometimes we may need a new pipeline for secondary viewports,.

Without this, vulkan validation layer will throw errors and a user may not know what to do.

This is the same patch, but updated to the latest upstream commit and to hopefully gain more attention. I have personally encountered this issue and requesting maintainers to push this upstream.

ocornut added a commit that referenced this pull request Apr 30, 2024
…indow::Pipeline (#6325, #6305, #7398, #3459, #3253, #3522)

As this is currently unused and misleading. Next commit will add a separate pipeline for secondary viewport.
ocornut pushed a commit that referenced this pull request Apr 30, 2024
…6325, #6305, #7398, #3459, #3253, #3522)

Edited from original commit: moved ImGui_ImplVulkan_CreatePipeline() call from ImGui_ImplVulkanH_CreateOrResizeWindow() to ImGui_ImplVulkan_CreateWindow().
@ocornut
Copy link
Owner

ocornut commented Apr 30, 2024

Now merged #6325

@ocornut ocornut closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants