Skip to content

Commit

Permalink
docs: add reference to reasoning behind the explicit return type (#204)
Browse files Browse the repository at this point in the history
  • Loading branch information
gr2m committed Feb 18, 2021
1 parent b7eebe4 commit 8671d2e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/webhooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import { Options } from "./types";
export function webhooks(
appOctokit: Octokit,
options: Required<Options>["webhooks"]
// Explict return type for better debugability and performance,
// see https://github.com/octokit/app.js/pull/201
): Webhooks<EmitterWebhookEvent & { octokit: Octokit }> {
return new Webhooks({
secret: options.secret,
Expand Down

0 comments on commit 8671d2e

Please sign in to comment.