[DONOTMERGE] Migrate dotnetcore to vs2017 tooling #1573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or vs201/csproj tool support
…emove $@ from build.sh script
…... i feel dirty but need to see if sudo will fix it!
…tched, as GitVersion was failing on TravisCI
This reverts commit cd66892.
On Windows, it will be installed by the Frosting bootstrapper script. On Unix/macOS, cake has smarts to look for mono- and Linux-specific executables
mono installation sometimes fails on macOS
|
It will be merged back into #1567, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temp PR working on top of of @ryangribble's amazing work at #1567 since I don't have push permission to that PR's source branch. I'm just trying to help here, by no means do I want this PR to be merged. If I get to something, I may create a PR that targets @ryangribble's PR branch, if he's willing to accept it.
He did make a lot of progress, namely:
I'm trying to work out the latest problem.
When on Unix and doing cross-targetting including a full .NET Framework TFM (which we have as Octokit builds for both
netstandard1.1andnet45), you have to let MSBuild know where the .NET fx reference assemblies are. That is not needed on Windows.Found an issue relating to this on the sdk repo: dotnet/sdk#335