Fix behaviour of bytes.split_multi to match string.split_multi

[Lperlind]

Before it was impossible to split on a substr that was not the smallest length, i.e.

test :: proc() {
    my_slice := []byte { 0, 1, 2, 0, 1, 2, 3, 4, 0, 0 }
    split := bytes.split_multi(my_slice, { { 1 }, { 3, 4 }})
    fmt.println(split) // prints [[0], [2, 0], [2, 3, 4, 0, 0]]
    // the real answer should be [[0], [2, 0], [2], [0, 0]]
}

Tested it with the following

test :: proc() {
    my_slice := []byte { 0, 0, 1, 2, 0, 1, 2, 3, 4, 0, 0 }

    split := bytes.split_multi(my_slice, { { 1 }, { 3, 4 }}, false, context.temp_allocator)
    fmt.println(split) // prints [[0], [2, 0], [2], [0, 0]]
    split_2 := bytes.split_multi(my_slice, { { 1, 2 }, { 3, 4 }}, false, context.temp_allocator)
    fmt.println(split_2) // prints [[0], [0], [], [0, 0]]
    split_3 := bytes.split_multi(my_slice, { { 1, 2 }, { 3, 4 }}, true, context.temp_allocator)
    fmt.println(split_3) // prints [[0], [0], [0, 0]]
    split_4 := bytes.split_multi(my_slice, { {  0, 1, 2, 0, 1, 2, 3, 4, 0, 0 }, { 0, 0 }}, true, context.temp_allocator)
    fmt.println(split_4) // prints [[1, 2, 0, 1, 2, 3, 4]]
    split_5 := bytes.split_multi(my_slice, { { 0 }, {  0, 1, 2, 0, 1, 2, 3, 4, 0 } }, true, context.temp_allocator)
    fmt.println(split_5) // prints []
    split_6 := bytes.split_multi(my_slice, { { 0 }, {  0, 1, 2, 0, 1, 2, 3, 4, 0 } }, false, context.temp_allocator)
    fmt.println(split_6) // prints [[], [], [], []]

    // ensure same behaviour between strings split multi (when skip_empty is set to true)
    as_string_test := "hello~~~world--split.multi!test"
    seps := []string { "~~~", "--", ".", "!" }
    string_split := strings.split_multi(as_string_test, seps, context.temp_allocator)
    fmt.println(string_split)
    string_split_bytes := transmute([]string)bytes.split_multi(transmute([]byte)as_string_test, transmute([][]byte)seps, true, context.temp_allocator)
    fmt.println(string_split_bytes)
    assert(len(string_split) == len(string_split_bytes))
    for _, i in string_split {
        assert(string_split[i] == string_split_bytes[i])
    }
}

[Lperlind]

Eh looks like I have some local changes in Odin causing the build errors, i'll fix those.

[Lperlind]

and I should probably do the iterator too...

[Kelimion]

If you want, feel free to add those tests to tests\core\... as well.