D3D12: Support for SHADER_4_COMPONENT_MAPPING macros #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirectX Shader Compiler
|
Did you even test this code before you wrote it? |
|
Sorry for the late replay. I'm actively using it in my renderer. I've also tested DECODE_SHADER_4_COMPONENT_MAPPING and it seems to work ok. What problem did you find? |
gingerBill
reviewed
May 18, 2023
Comment on lines
+502
to
+509
| ENCODE_SHADER_4_COMPONENT_MAPPING :: proc(Src0, Src1, Src2, Src3: SHADER_COMPONENT_MAPPING) -> u32 { | ||
| return (u32(Src0)&SHADER_COMPONENT_MAPPING_MASK)| | ||
| ((u32(Src1)&SHADER_COMPONENT_MAPPING_MASK)<<SHADER_COMPONENT_MAPPING_SHIFT)| | ||
| ((u32(Src2)&SHADER_COMPONENT_MAPPING_MASK)<<(SHADER_COMPONENT_MAPPING_SHIFT*2))| | ||
| ((u32(Src3)&SHADER_COMPONENT_MAPPING_MASK)<<(SHADER_COMPONENT_MAPPING_SHIFT*3))| | ||
| SHADER_COMPONENT_MAPPING_ALWAYS_SET_BIT_AVOIDING_ZEROMEM_MISTAKES | ||
| } | ||
| DECODE_SHADER_4_COMPONENT_MAPPING :: proc(ComponentToExtract, Mapping: u32) -> SHADER_COMPONENT_MAPPING { |
There was a problem hiding this comment.
I recommend making these proc "c" or something that is the default "odin" calling convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added procedures for D3D12 macros:
ENCODE_SHADER_4_COMPONENT_MAPPING
DECODE_SHADER_4_COMPONENT_MAPPING
Added a "runtime constant" for
DEFAULT_SHADER_4_COMPONENT_MAPPING