Adding IUserDefinedAnnotation to D3D11 for better debugging. #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerBill
reviewed
Dec 2, 2023
vendor/directx/d3d11/d3d11.odin
Outdated
Comment on lines
3288
to
3289
| #subtype iunknown : IUnknown, | ||
| using id3d11userdefinedannotation_vtable : ^IUserDefinedAnnotation_VTable, |
There was a problem hiding this comment.
Missing indentation and bind the : to the identifer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I think adding
IUserDefinedAnnotationto the D3D11 vendor package makes sense since it makes debugging in graphics debuggers way nicer.Only concern might be that this is not guaranteed to be supported by Windows 7 since it's in d3d11_1.h: https://learn.microsoft.com/en-us/windows/win32/api/d3d11_1/nn-d3d11_1-id3duserdefinedannotation