-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows additions #3040
Open
NicknEma
wants to merge
33
commits into
odin-lang:master
Choose a base branch
from
NicknEma:windows_additions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Windows additions #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some missing declarations, started reordering
Reordered functions from "Windows and Messages" section
Added "A" procedures
Added "B" functions
Added HDWP
Removed semicolons and a comment
Some functions returned "int" where they should've returned a "c_int".
Added "S", "T", "U" and "W" procedures from "Windows and Messages" section
Added SENDASYNCPROC
Some more fixes to slightly incorrect function signatures (es. int vs c_int), minor stylistic changes and some todo comments.
flysand7
reviewed
Dec 21, 2023
gingerBill
reviewed
Jan 2, 2024
No more *A versions of procedures, at least in user32.odin. I also finished adding all those stubs I left commented out before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to add missing bindings for user32, and the required types; to make the process easier, I sorted the list alphabetically, that's why it looks like a lot of lines were deleted. I also fixed some incorrect existing declarations (for example, they used int instead of c_int/i32) and added some comments.