Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core:time - Added stopwatch procs to return the duration in relevant procedures. Added naming suggestion. #3128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core:time - Added stopwatch procs to return the duration in relevant procedures. Added naming suggestion. #3128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions core/time/time.odin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,19 @@ stopwatch_start :: proc "contextless" (stopwatch: ^Stopwatch) {
}
}

stopwatch_stop :: proc "contextless" (stopwatch: ^Stopwatch) {
stopwatch_stop :: proc "contextless" (stopwatch: ^Stopwatch) -> (duration_running: Duration) {
if stopwatch.running {
stopwatch._accumulation += tick_diff(stopwatch._start_time, tick_now())
stopwatch.running = false
}
return stopwatch._accumulation
}

stopwatch_reset :: proc "contextless" (stopwatch: ^Stopwatch) {
stopwatch_reset :: proc "contextless" (stopwatch: ^Stopwatch) -> (duration_running: Duration) {
duration_running = stopwatch._accumulation
stopwatch._accumulation = {}
stopwatch.running = false
return duration_running
}

stopwatch_duration :: proc "contextless" (stopwatch: Stopwatch) -> Duration {
Expand Down Expand Up @@ -119,6 +122,18 @@ duration_hours :: proc "contextless" (d: Duration) -> f64 {
return f64(hour) + f64(nsec)/(60*60*1e9)
}

/*
Note(Dragos): This is a renaming suggestion to make the Duration conversion naming be on par with the Time conversion.
Added them as aliases as to not cause breaking changes, and would still allow people to grep/search for duration_* equivalent procs
These is just an idea, so feel free to remove it if it's inconsistent with other core-libs principles.
*/
nanoseconds :: duration_nanoseconds
microseconds :: duration_microseconds
milliseconds :: duration_milliseconds
seconds :: duration_seconds
minutes :: duration_minutes
hours :: duration_hours

duration_round :: proc "contextless" (d, m: Duration) -> Duration {
_less_than_half :: #force_inline proc "contextless" (x, y: Duration) -> bool {
return u64(x)+u64(x) < u64(y)
Expand Down