core/bytes: Tweak index_byte
/last_index_byte
#4101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also think
last_index_byte
would crash ifs == nil
(at least it looks suspicious). This is objectively worse on huges
with the character at the tail, if the starting address is not 16 or 32-byte aligned (depending on microarch), because the penalties will add up. I don't particularly think that case is worth optimizing for (and this has a code-path for < 4*SIMD_REG_SIZE), so it should be better on reasonable inputs.