[v1.22.x]prov/efa: always use p2p for system memory #10397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should you backport all 2 commits in #10392? Same for the other backport |
|
I saw the older branches did not have the p2p_available variable so I didn't backport the other commit |
Then you should backport #10347 as well? |
Currently EFA provider doesn't handle the fi_sendmsg call with FI_INJECT flags correctly. It allows user to pass in a buffer with valid MR while doing inject - outbound buffer should be reusable immediately after function returns. That being said, without the inline HW support, EFA provider should do a copy from the user buffer to the internal bounce buffer even if application provides a valid MR for the buffer. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com> (cherry picked from commit 22be7e0)
fi_writemsg with FI_INJECT needs to copy from outbound buffer to internal bounce buffer. The outbound buffer can be non-system. Extract and call a helper function for device to host copy. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com> (cherry picked from commit 1b3fb77)
P2P is always available for host memory. Unregistered buffer will be regarded as host memory as EFA provider requires FI_MR_HMEM. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com> (cherry picked from commit b0af713)
Rename to mr_p2p_available to indicate that we check the mr is not NULL. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com> (cherry picked from commit 677bdeb)
jiaxiyan
force-pushed
the
backport_10392_v1.22.x
branch
from
e71c68f
to
49c4b89
Compare
shijin-aws
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10347 and #10392