prov/rxd: replacing statically allocated arrays with ofi index_map and ofi indexer. #6110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikhilnanal
commented
Jul 21, 2020
•
nikhilnanal
commented
- replaced peers array in rxd_ep to an index_map based implementation.
- replaced fi_addr_table in rxd_av to an indexer based implementation.
nikhilnanal
changed the title
shefty
reviewed
Jul 21, 2020
|
force pushed after updating some of the review comments |
|
Please check the changes and verify that fabtests pass prior to re-pushing. I didn't see anything specific that stood out reading through the latest changes, but something is off somewhere looking at CI results. |
The peers array in the endpoint structure is dynamically allocated but is not extensible. Replacing this array with an ofi_index map which will provide the capability to increase the number of peers upto 1 million peers without increasing static memory consumption. Signed-off-by: Nikhil Nanal <nikhil.nanal@intel.com>
The fi_addr_table is currently implemented as a array of fixed size. Changing this to an ofi_indexer based implementation to provide extensibility upto 1 million entries and insertion to first available location. Signed-off-by: Nikhil Nanal <nikhil.nanal@intel.com>
Replacing the fixed size array of rxd_addr_table in the rxd_av to using an indexer (rxdaddr_dg_indexer) to store addresses stored by the underlying dg_provider and an index map (rxdaddr_fi_idm) to store the fi_addrs used by the application. The indexer indices start from 1, but the corresponding fi_addrs provided to the application begin from 0. Introduced RXD_ADDR_INVALID = 0 to represent an invalid address for rxd_addr. Signed-off-by: Nikhil Nanal <nikhil.nanal@intel.com>
nikhilnanal
force-pushed
the
feat_dynAV4
branch
2 times, most recently
from
41f1b88
to
96bd8bf
Compare
|
Submitted patch #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.