Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonce issue for replay attack #544

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Conversation

summerpro
Copy link
Contributor

@summerpro summerpro commented Jan 8, 2021

Closes: cosmos/ethermint#687

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

Merging #544 (1be8fd3) into dev (f433c50) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #544   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files         303      303           
  Lines       18370    18370           
=======================================
  Hits        12523    12523           
  Misses       5131     5131           
  Partials      716      716           
Impacted Files Coverage Δ
app/rpc/namespaces/eth/api.go 0.00% <0.00%> (ø)
app/ante/eth.go 58.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f433c50...1be8fd3. Read the comment docs.

@KamiD KamiD merged commit b6dc1e0 into dev Jan 8, 2021
@zhongqiuwood zhongqiuwood deleted the ray/Fix-nonce-issue-for-replay-attack branch January 12, 2021 23:20
@summerpro summerpro mentioned this pull request Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay Tx on another Chain
6 participants