-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTED]Added Auto Contract button next to ask for easier & changed emoji for easier button #5573
base: master
Are you sure you want to change the base?
Conversation
This way it stands out from the auto farming contract and auto Farm buttons
This way we don't have to scroll back up in order to press the farming contract button again and prevents people from accidentally asking for an easier contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently you've only changed the emoji, this is an empty commit.
I saw in the closed pr that you do have the code for the suggested button change.
Unsure if a dice is a suitable alternative emoji (but not up to me)
so for the life of me I'm not sure what happened to the file I had saved that had all the error fixing already done so I just went through it all again. but it is now back to where it was before with circular tests failing, which @themrrobert said is something I can't do on my own. and @themrrobert gave me the idea of changing the one emoji and when I asked for suggestions he came up with the dice. |
Your circular dependency issue can be fixed by adding: const autoContractButton = new ButtonBuilder() before the farmingContractCommand function. tested here: https://discord.com/channels/940758552425955348/1162793245194072074/1195448092665847831 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this. I see what you did and makes so much more sense now.
Do you have a test bot you're testing this on? |
unfortunately not. cyr also worked with me on the coding for this one too. |
I tested it here: https://discord.com/channels/940758552425955348/1162793245194072074/1195448092665847831 after i helped fix the circular issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
@gc @themrrobert any chance this PR can get looked over to be merged?
Description:
help it stand out from the auto farming contract button
![Screenshot_20240109_201433_Discord](https://private-user-images.githubusercontent.com/133211494/296171858-bcf90f12-2e8b-4017-b76b-30e5cb1fcfda.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxNjEwMDgsIm5iZiI6MTcyMDE2MDcwOCwicGF0aCI6Ii8xMzMyMTE0OTQvMjk2MTcxODU4LWJjZjkwZjEyLTJlOGItNDAxNy1iNzZiLTMwZTVjYjFmY2ZkYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwNVQwNjI1MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01YzE1YTFiMDZjMWRhMjAwYjI2MDNjMWFlMzllNWZmMDJiYmUzMmYzOTU1YTI4ZWU2NjJhMDFiNDg5ZjQ3N2M3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.StB3Ig2WhXObXbr8UDX-Bk_NeTiCDva3tQFNdXsPXJw)
Changes:
Other checks:
screenshot of change
![SmartSelect_20240427_061146_Discord.png](https://github.com/oldschoolgg/oldschoolbot/assets/133211494/ca3a2cf8-1bf9-4b81-9df3-e367462e4cc3)