Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Drop the fax field #388

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
### Deprecated

### Removed
- Drop the `fax` field (#388)
- Drop support for TYPO3 10LTS (#387)
- Drop support for PHP 7.2/7.3 (#386)

Expand Down
16 changes: 0 additions & 16 deletions Classes/Domain/Model/FrontendUser.php
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,6 @@ class FrontendUser extends AbstractEntity
*/
protected $telephone = '';

/**
* @var string
* @Extbase\Validate("StringLength", options={"maximum": 30})
*/
protected $fax = '';

/**
* @var string
* @Extbase\Validate("StringLength", options={"maximum": 255})
Expand Down Expand Up @@ -380,16 +374,6 @@ public function setTelephone(string $telephone): void
$this->telephone = $telephone;
}

public function getFax(): string
{
return $this->fax;
}

public function setFax(string $fax): void
{
$this->fax = $fax;
}

public function getEmail(): string
{
return $this->email;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<last_name>Minimau</last_name>
<address>Near the heating 4</address>
<telephone>+49 1111 1233456-78</telephone>
<fax>+49 1111 1233456-79</fax>
<email>max@example.com</email>
<title>Head of fur</title>
<zip>01234</zip>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ public function findByUidForExistingRecordReturnsModelWithAllScalarData(): void
self::assertSame('Minimau', $model->getLastName());
self::assertSame('Near the heating 4', $model->getAddress());
self::assertSame('+49 1111 1233456-78', $model->getTelephone());
self::assertSame('+49 1111 1233456-79', $model->getFax());
self::assertSame('max@example.com', $model->getEmail());
self::assertSame('Head of fur', $model->getTitle());
self::assertSame('01234', $model->getZip());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ public function findByUidForExistingRecordReturnsModelWithAllScalarData(): void
self::assertSame('Minimau', $model->getLastName());
self::assertSame('Near the heating 4', $model->getAddress());
self::assertSame('+49 1111 1233456-78', $model->getTelephone());
self::assertSame('+49 1111 1233456-79', $model->getFax());
self::assertSame('max@example.com', $model->getEmail());
self::assertSame('Head of fur', $model->getTitle());
self::assertSame('01234', $model->getZip());
Expand Down
22 changes: 0 additions & 22 deletions Tests/Unit/Domain/Model/FrontendUserTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -347,28 +347,6 @@ public function setTelephoneSetsTelephone(): void
self::assertSame($telephone, $this->subject->getTelephone());
}

/**
* @test
*/
public function getFaxInitiallyReturnsEmptyString(): void
{
$result = $this->subject->getFax();

self::assertSame('', $result);
}

/**
* @test
*/
public function setFaxSetsFax(): void
{
$fax = '42';

$this->subject->setFax($fax);

self::assertSame($fax, $this->subject->getFax());
}

/**
* @test
*/
Expand Down