Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Migrate some legacy model tests #2768

Merged
merged 1 commit into from
Dec 10, 2023
Merged

[TASK] Migrate some legacy model tests #2768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
- Drop unused Composer scripts and add script descriptions (#2740)
- Migrate the tests to the TYPO3 testing framework
(#2701, #2702, #2713, #2717, #2731, #2732, #2733, #2734, #2735, #2737, #2739,
#2742, #2754, #2756, #2757, #2760, #2764, #2767)
#2742, #2754, #2756, #2757, #2760, #2764, #2767, #2768)

### Deprecated

Expand Down
15 changes: 11 additions & 4 deletions ...LegacyUnit/OldModel/AbstractModelTest.php → ...Functional/OldModel/AbstractModelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,24 @@

declare(strict_types=1);

namespace OliverKlee\Seminars\Tests\LegacyUnit\OldModel;
namespace OliverKlee\Seminars\Tests\LegacyFunctional\OldModel;

use OliverKlee\Oelib\Testing\TestingFramework;
use OliverKlee\Seminars\Tests\Unit\OldModel\Fixtures\TestingModel;
use PHPUnit\Framework\TestCase;
use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;

/**
* @covers \OliverKlee\Seminars\OldModel\AbstractModel
*/
final class AbstractModelTest extends TestCase
final class AbstractModelTest extends FunctionalTestCase
{
protected $testExtensionsToLoad = [
'typo3conf/ext/static_info_tables',
'typo3conf/ext/feuserextrafields',
'typo3conf/ext/oelib',
'typo3conf/ext/seminars',
];

/**
* @var TestingModel
*/
Expand Down Expand Up @@ -61,7 +68,7 @@ protected function setUp(): void

protected function tearDown(): void
{
$this->testingFramework->cleanUp();
$this->testingFramework->cleanUpWithoutDatabase();

parent::tearDown();
}
Expand Down
15 changes: 11 additions & 4 deletions ...gacyUnit/OldModel/LegacyOrganizerTest.php → ...nctional/OldModel/LegacyOrganizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,24 @@

declare(strict_types=1);

namespace OliverKlee\Seminars\Tests\LegacyUnit\OldModel;
namespace OliverKlee\Seminars\Tests\LegacyFunctional\OldModel;

use OliverKlee\Oelib\Testing\TestingFramework;
use OliverKlee\Seminars\OldModel\LegacyOrganizer;
use PHPUnit\Framework\TestCase;
use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;

/**
* @covers \OliverKlee\Seminars\OldModel\LegacyOrganizer
*/
final class LegacyOrganizerTest extends TestCase
final class LegacyOrganizerTest extends FunctionalTestCase
{
protected $testExtensionsToLoad = [
'typo3conf/ext/static_info_tables',
'typo3conf/ext/feuserextrafields',
'typo3conf/ext/oelib',
'typo3conf/ext/seminars',
];

/**
* @var LegacyOrganizer
*/
Expand Down Expand Up @@ -59,7 +66,7 @@ protected function setUp(): void

protected function tearDown(): void
{
$this->testingFramework->cleanUp();
$this->testingFramework->cleanUpWithoutDatabase();

parent::tearDown();
}
Expand Down
15 changes: 11 additions & 4 deletions ...egacyUnit/OldModel/LegacyTimeSlotTest.php → ...unctional/OldModel/LegacyTimeSlotTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,31 @@

declare(strict_types=1);

namespace OliverKlee\Seminars\Tests\LegacyUnit\OldModel;
namespace OliverKlee\Seminars\Tests\LegacyFunctional\OldModel;

use OliverKlee\Oelib\Configuration\ConfigurationRegistry;
use OliverKlee\Oelib\Configuration\DummyConfiguration;
use OliverKlee\Oelib\Testing\TestingFramework;
use OliverKlee\Seminars\Tests\Support\LanguageHelper;
use OliverKlee\Seminars\Tests\Unit\OldModel\Fixtures\TestingLegacyTimeSlot;
use PHPUnit\Framework\TestCase;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;

/**
* @covers \OliverKlee\Seminars\OldModel\LegacyTimeSlot
*/
final class LegacyTimeSlotTest extends TestCase
final class LegacyTimeSlotTest extends FunctionalTestCase
{
use LanguageHelper;

protected $testExtensionsToLoad = [
'typo3conf/ext/static_info_tables',
'typo3conf/ext/feuserextrafields',
'typo3conf/ext/oelib',
'typo3conf/ext/seminars',
];

/**
* @var TestingLegacyTimeSlot
*/
Expand Down Expand Up @@ -60,7 +67,7 @@ protected function setUp(): void

protected function tearDown(): void
{
$this->testingFramework->cleanUp();
$this->testingFramework->cleanUpWithoutDatabase();

parent::tearDown();
}
Expand Down