Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open ID Connect #300

Closed
synotna opened this issue Jun 18, 2014 · 11 comments
Closed

Open ID Connect #300

synotna opened this issue Jun 18, 2014 · 11 comments

Comments

@synotna
Copy link
Contributor

synotna commented Jun 18, 2014

Am I correct in understanding that Open ID Connect ( http://openid.net/connect/ ) is not supported yet?

@omab
Copy link
Owner

omab commented Jun 18, 2014

You are right, it's not supported yet.

@synotna
Copy link
Contributor Author

synotna commented Jun 18, 2014

Has any work already been done towards it, or do you have any idea how difficult it will be to implement with the existing structure?

@omab
Copy link
Owner

omab commented Jun 18, 2014

I have no idea, wasn't aware of this stuff until you pointed that, it's probably not very hard to implement, just need time to review and plan the work.

@synotna
Copy link
Contributor Author

synotna commented Jun 18, 2014

I've found only one other Python implementation so far, https://github.com/rohe/pyoidc

The other libraries seem to be in the same situation

Thanks!

@omab
Copy link
Owner

omab commented Jun 18, 2014

Checking the protocol definition and the the basic client implementation, it's really similar to OAuth2 backends but with the forced openid scope set, so I wonder if that's pretty much what we need to make it work.

Google already implements this protocol AFAIK, so this will be useful to test it:

SOCIAL_AUTH_GOOGLE_OAUTH2_SCOPE = ['openid']
SOCIAL_AUTH_GOOGLE_OAUTH2_EXTRA_DATA = ['id_token', 'refresh_token']

@synotna
Copy link
Contributor Author

synotna commented Jun 19, 2014

Google Open ID Connect is now working for me, and our in house open id once I configured it to use the Authorization header method

That is the preferred method by Google, https://developers.google.com/accounts/docs/OAuth2WebServer#callinganapi so maybe it is best to change the defaults?

Thanks for getting it working so quickly!

@synotna
Copy link
Contributor Author

synotna commented Jun 23, 2014

When will you push the update to pypi? :)

@omab
Copy link
Owner

omab commented Jun 23, 2014

I don't have a date yet, I need to work in the docs and update and comment about the backward incompatible changes.

@kakky
Copy link

kakky commented Jul 29, 2014

@clintonb
Copy link
Contributor

clintonb commented Aug 8, 2014

I combined the work of @omab and @kakky to make an extendable OpenIdConnect consumer for a project I am working on: https://gist.github.com/clintonb/6ee13e39ca6cc5c56c49.

@omab
Copy link
Owner

omab commented Dec 13, 2016

Fix already merged.

@omab omab closed this as completed Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants