Fixed Django < 1.4 support in context processors. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to Django commit 60cf3f2f842b6e56132b8880c70acc87bd753c, Django was using None as a sentinel value.
omab
added a commit
that referenced
this pull request
Mar 9, 2014
Fixed Django < 1.4 support in context processors.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Django commit 60cf3f2f842b6e56132b8880c70acc87bd753c,
Django was using
Noneas a sentinel value.The existing code in place to support Django 1.3 would not actually work.
I would have added some tests with this pull request but couldn't figure out where to put them.
I couldn't find which versions of Django you're supporting either, but note that in 1.6, Django added
__getitem__and__setitem__methods onLazyObjectso if/when you drop support for older versions, you can use a plainSimpleLazyObjectinstead of your customLazyDict.