Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Django 1.7 migrations #318

Merged
merged 1 commit into from
Jul 7, 2014
Merged

Added Django 1.7 migrations #318

merged 1 commit into from
Jul 7, 2014

Conversation

ondrowan
Copy link
Contributor

@ondrowan ondrowan commented Jul 1, 2014

I've added initial migration that's required in Django 1.7. I've tried it with most recent RC and it works well. The only problem is that social-auth hadn't used South migrations before and new folder migrations is backwards incompatible for users that still use South. AFAIK the only solution should be to create South migrations folder (eg. south_migrations) and tell users to use following setting:

SOUTH_MIGRATION_MODULES = {
    'social_auth': 'social_auth.path.to.django_app.south_migrations',
}

Or possibly the other way around. Rename this new folder to django_migrations and create new migrations folder with South migrations. But that seems to be more complicated option.

Feedback is welcome as I'm not 100% sure how to handle this situation.

Related to #270.

@ondrowan
Copy link
Contributor Author

ondrowan commented Jul 1, 2014

Coincidentally, South 1.0 was released today.

omab added a commit that referenced this pull request Jul 7, 2014
Added Django 1.7 migrations
@omab omab merged commit 62fa600 into omab:master Jul 7, 2014
@omab
Copy link
Owner

omab commented Jul 7, 2014

Thanks!

Regarding South migrations, they should be added to south_migration folder as suggested IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants