Use official python-saml 2.1.3 release, remove now-unsupported setting #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omab
added a commit
that referenced
this pull request
Jul 9, 2015
Use official python-saml 2.1.3 release, remove now-unsupported setting
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML backend can now use the latest official release of python-saml, rather than a fork, since the release now includes the required changes. Version 2.1.3 is largely the same as the commit hash previously specified, with one notable difference being that the "NameIDFormats" setting change that I had proposed was rejected in favor of a simpler fix that should meet the same goals.
So, this PR:
NameIDFormatssetting, which was unlikely to be needed by most people anyways. Those who do need to override theNameIDFormatcan configure it using theSOCIAL_AUTH_SAML_SP_EXTRAdict, but that is unlikely to be a common requirement.