Commits on Jul 10, 2015

1. Fix redirect_uri issue with tornado reversed url …

   When reversing URLs, tornado doesn't interpret the regex optional symbol
   '?'. This causes the redirect_uri to be
   https://example.com/complete/mybackend/? with the question mark
   appended. Some providers will simply append to this uri, causing URLs
   like https://example.com/complete/mybackend/??code=.... with two
   question marks. This makes the interpretation of the query string fail.
   
   The provider in this case is
   https://github.com/juanifioren/django-oidc-provider. Arguably that
   library should be smarter in constructing the redirection, but removing
   the question mark from the uri solves these kind of issues.
   
   Alternatively we could strip the question mark from the uri in the
   tornado strategy, but this seemed simpler.

   

   MaartenKos committed Jul 10, 2015
   Configuration menu

   • View commit details
   • Copy full SHA for e17367b
   • Browse repository at this point

   Copy the full SHA

   e17367b View commit details

   Browse the repository at this point in the history