Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Django 1.10 deprecation warnings #806

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Fix Django 1.10 deprecation warnings #806

merged 1 commit into from
Jan 14, 2016

Conversation

yprez
Copy link
Contributor

@yprez yprez commented Dec 16, 2015

In django_app/urls.py:

  • Use a list instead of patterns
  • Use view callables instead of strings

Fixes #804, #754

@yprez
Fix Django 1.10 deprecation warnings
eca0f26 
In django_app/urls.py:
* Use a list instead of `patterns`
* Use view callables instead of strings

Fixes omab#804, omab#754
@alexandrevicenzi
Copy link

👍

@contracode contracode mentioned this pull request Dec 30, 2015
Merged
@gustavi gustavi mentioned this pull request Jan 6, 2016
Closed
4 tasks
@gustavi
Copy link

gustavi commented Jan 7, 2016

The code is OK, somebody can merge it ?

@yprez
Copy link
Contributor Author

yprez commented Jan 7, 2016

@omab there are several PRs addressing this and other compatibility issues, is there any chance you can review/merge/close some of them?

@gustavi
Copy link

gustavi commented Jan 10, 2016

Some news ?

@omab
Copy link
Owner

omab commented Jan 10, 2016

Will take a look asap.

@gustavi
Copy link

gustavi commented Jan 14, 2016

?

It's just a code review, please merge it ASAP.

@omab omab merged commit eca0f26 into omab:master Jan 14, 2016
@omab
Copy link
Owner

omab commented Jan 14, 2016

Thanks @yprez, merged.

@gustavi it's not just "code review", and it also takes time.

@gustavi
Copy link

gustavi commented Jan 14, 2016

Thank you.

@yprez
Copy link
Contributor Author

yprez commented Jan 14, 2016

Thanks @omab !

I'll try fixing the other deprecation issues, or finding PRs that already do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yprez @alexandrevicenzi @gustavi @omab