Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise Http404 in django auth view when the backend is not found #83

Merged
merged 1 commit into from
Nov 13, 2013
Merged

Raise Http404 in django auth view when the backend is not found #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions social/apps/django_app/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from django.conf import settings
from django.core.urlresolvers import reverse
from django.http import Http404

from social.utils import setting_name, module_member
from social.strategies.utils import get_strategy
Expand All @@ -27,10 +28,13 @@ def wrapper(request, backend, *args, **kwargs):
uri = redirect_uri
if uri and not uri.startswith('/'):
uri = reverse(redirect_uri, args=(backend,))
request.social_strategy = load_strategy(
request=request, backend=backend,
redirect_uri=uri, *args, **kwargs
)
try:
request.social_strategy = load_strategy(
request=request, backend=backend,
redirect_uri=uri, *args, **kwargs
)
except ValueError: # no such backend
raise Http404
# backward compatibility in attribute name, only if not already
# defined
if not hasattr(request, 'strategy'):
Expand Down