Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django 1.8+ compat to ensure to_python is always called when accessing result from db.. #897

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

sbussetti
Copy link
Contributor

Without this extra_data field can be returned as its raw serialized string...

@clintonb
Copy link
Contributor

This issue was introduced by #813. Django docs for reference: https://docs.djangoproject.com/en/1.9/howto/custom-model-fields/#converting-values-to-python-objects.

@sbussetti
Copy link
Contributor Author

@clintonb yeah, the author of that patch removed SubFieldBase without reading the rest of the deprecation instructions from the Django docs which instruct you to provide from_db_value going forward. Not that it matters to me, but #813 would also break backwards compat...

@omab omab merged commit 089bc65 into omab:master Apr 20, 2016
clintonb referenced this pull request in openedx-unsupported/edx-analytics-dashboard Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants