Extend test coverage for tables slice, read and readCoordinates API #6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add test case for the special handling of empty inputs in table.slice - add various test cases for invalid inputs in the table reading API
sbesson
force-pushed
the
table_more_tests
branch
from
10bd624
to
03544ac
Compare
sbesson
force-pushed
the
table_more_tests
branch
from
03544ac
to
e910665
Compare
chris-allan
approved these changes
Sep 19, 2024
|
Added a few tests around the the expectations of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6411 (comment) for the initial motivation.
The contract around the handling of empty inputs in the
omero.tables.sliceAPI is currently solely documented in the slicegenerated API documentation - see https://docs.openmicroscopy.org/omero-blitz/5.7.3/slice2html/omero/grid/Table.html#slice.
This PR expands the table integration tests to check different scenarios including:
tables.slicetables.slice,tables.readandtables.readCoordinatestables.sliceThe new tests are expected to pass with the current version of OMERO.py. As part of this, I have identified an issue when
start/stopare outside the rows range intable.read()which I will address separetely.