fix test

omnipay-taiwan · Nov 11, 2023 · 7431054 · 7431054
1 parent fb1249e
commit 7431054
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/tests/GatewayTest.php b/tests/GatewayTest.php
@@ -2,6 +2,7 @@
 
 namespace Omnipay\ECPay\Tests;
 
+use Omnipay\Common\Message\NotificationInterface;
 use Omnipay\ECPay\Gateway;
 use Omnipay\ECPay\Tests\Stubs\StubGateway;
 use Omnipay\Tests\GatewayTestCase;
@@ -89,11 +90,11 @@ public function testAcceptNotification()
  'TradeNo' => '1909021549160081',
  'CheckMacValue' => 'E7EC8DDC6C5C51B1A4D8BEA261246066858B38184C55FD3DD3D6DFF53F535A64',
  ]);
- $response = $this->gateway->acceptNotification()->send();
+ $notification = $this->gateway->acceptNotification();
 
- self::assertTrue($response->isSuccessful());
- self::assertEquals('Succeeded', $response->getMessage());
- self::assertEquals('1|OK', $response->getReply());
+ self::assertEquals(NotificationInterface::STATUS_COMPLETED, $notification->getTransactionStatus());
+ self::assertEquals('Succeeded', $notification->getMessage());
+ self::assertEquals('1|OK', $notification->getReply());
  }
 
  public function testFetchTransaction()

diff --git a/tests/Message/AcceptNotificationRequestTest.php b/tests/Message/AcceptNotificationRequestTest.php
@@ -90,14 +90,14 @@ public function testInvalidCheckMacValue()
  ];
 
  $this->getHttpRequest()->request->add($data);
- $request = new AcceptNotificationRequest($this->getHttpClient(), $this->getHttpRequest());
- $request->initialize([
+ $notification = new AcceptNotificationRequest($this->getHttpClient(), $this->getHttpRequest());
+ $notification->initialize([
  'HashKey' => '5294y06JbISpM5x9',
  'HashIV' => 'v77hoKGq4kWxNNIS',
  'EncryptType' => '1',
  'MerchantID' => '2000132',
  ]);
- $request->setTestMode(true);
- $request->send();
+ $notification->setTestMode(true);
+ $notification->getTransactionStatus();
  }
 }