Second patch of bumping adapters branch #1014

omarahmed1111 · 2023-10-30T10:58:27Z

bump adapters branch to catch to main till this commit. This is a continuation of this PR

Intel/LLVM testing and adding some fixes on intel/llvm side associated to this changes: here

Make urInit and urTearDown loader-only

…d-native-context-handle-cts [UR] Fix urContextNativeHandle CTS

- Adds USM and Buffer fill append commands - Update feature spec for new commands - Align naming conventions for Append* commands with core equivalents

[EXP][CMDBUF] Add fill commands to cmd buffer experimental feature

[UR][CTS] Upstream CTS parser

[UR] Fixup minor CTS issues

Fuzz tests set up with cron don't run because cron scheduled workflows are triggered only for the default branch. Add nightly workflow file to the default branch with fuzz tests specified to run on 'adapters' branch.

Taken from: kilobyte/critnib@fae4b85

This implementation is lock-free and does not require C++ runtime.

Implement locks using C++ std::mutex and atomics by using Interlocked* functions and calling _ReadWriteBarrier

[main] Speed up CI jobs

Move nightly CI tests to the main branch

[umf] extend error message for disjoint pool

[UR] Fix program CTS assesion checks

[umf] implement memory tracking using critnib

- Added extra conditions to the validation layers of urEnqueueMemBufferFill, urEnqueueMemImageCopy, urEnqueueMemImageWrite and urEnqueueMemImageReady

The AppleClang compiler emits warnings in C functions with zero arguments that are not specified as `f(void)`.

[umf] Fix macOS build

…changes-into-adapters

EwanC

command-buffer changes LGTM, this PR is very helpful in unblocking some other changes we have pending.

isaacault

Bindless Images LGTM!

source/adapters/cuda/common.cpp

…me-main-changes-into-adapters-second-patch

…cond-patch

Seanst98

My commit adding unique addressing modes per dimension for the bindless images extension found here and PR here has been added in this bump.

At the time, UR did not support C style arrays so the above commit compromised by using 3 different vars to represent each dimension and was merged into main. A new commit was pushed to main and merged here and PR here which added C style array support and modified the extension to use C style arrays.

I can't find the commits which update to using C style arrays in this bump. Can we add it?

kbenzie · 2023-11-13T14:41:48Z

I can't find the commits which update to using C style arrays in this bump. Can we add it?

We've split up the main bumps because that was easier to handle the issues which arose from this process. We will be pulling in the rest of the changes from main in a third PR. Then, I think we'll merge them all back to back so they should land in adapters branch at the same time.

Seanst98 · 2023-11-13T15:08:09Z

I can't find the commits which update to using C style arrays in this bump. Can we add it?

We've split up the main bumps because that was easier to handle the issues which arose from this process. We will be pulling in the rest of the changes from main in a third PR. Then, I think we'll merge them all back to back so they should land in adapters branch at the same time.

Ah, that's great. Thanks!

…cond-patch

omarahmed1111 · 2023-11-16T15:44:40Z

Due to a windows failure that will be fixed here and to make it easier, we will combine the second and third bump into one here. So closing this for now.

Petr Vesely and others added 30 commits August 21, 2023 09:16

[UR][CTS] Upstream CTS parser

8214bf2

[umf] extend error message for disjoint pool

0625273

Make urInit and urTearDown loader-only

17e719f

Merge pull request oneapi-src#793 from callumfare/callum/loader_init

f7682a2

Make urInit and urTearDown loader-only

[UR] Refactor CTS parser to use JSON output from tests

790384e

Merge pull request oneapi-src#822 from veselypeta/petr/820/fix-invali…

2118102

…d-native-context-handle-cts [UR] Fix urContextNativeHandle CTS

[CMDBUF] Add fill commands to cmd buffer exp feature

40a6846

- Adds USM and Buffer fill append commands - Update feature spec for new commands - Align naming conventions for Append* commands with core equivalents

[UR] List available tests and track crashes

26b9d82

Merge pull request oneapi-src#818 from Bensuo/cmd-buffer-fill

19f391b

[EXP][CMDBUF] Add fill commands to cmd buffer experimental feature

[UR] Fetch testsuite names from ctest

b079f63

Merge pull request oneapi-src#810 from veselypeta/petr/port-ctest-parser

04bd987

[UR][CTS] Upstream CTS parser

[UR] Fixup minor CTS issues

2580e08

Fix device CTS tests (oneapi-src#834)

a8e4955

Merge pull request oneapi-src#835 from veselypeta/petr/fixup-cts

4ce5cdd

[UR] Fixup minor CTS issues

Move nightly CI tests to the main branch

fd93ee0

Fuzz tests set up with cron don't run because cron scheduled workflows are triggered only for the default branch. Add nightly workflow file to the default branch with fuzz tests specified to run on 'adapters' branch.

Speed up CI jobs

7b5956a

[umf] add critnib datastructure

4c7cb30

Taken from: kilobyte/critnib@fae4b85

[umf] replace memory tracker with a critnib-based impl

c8a2d34

This implementation is lock-free and does not require C++ runtime.

[umf] add windows support to critnib

fe44f26

Implement locks using C++ std::mutex and atomics by using Interlocked* functions and calling _ReadWriteBarrier

Merge pull request oneapi-src#846 from PatKamin/main-shorten-ci

273c82b

[main] Speed up CI jobs

Merge pull request oneapi-src#844 from PatKamin/fix-nightly-tests

022bbae

Move nightly CI tests to the main branch

Merge pull request oneapi-src#841 from igchor/disjoint_pool_extend_error

eb061c8

[umf] extend error message for disjoint pool

[UR] Fix program CTS assesion checks

845357b

Merge pull request oneapi-src#850 from veselypeta/petr/fix-program-cts

a3120e7

[UR] Fix program CTS assesion checks

Merge pull request oneapi-src#796 from igchor/umf_critnib

6d59b4c

[umf] implement memory tracking using critnib

Update specification for urEnqueue entrypoints (oneapi-src#851)

2c533e6

- Added extra conditions to the validation layers of urEnqueueMemBufferFill, urEnqueueMemImageCopy, urEnqueueMemImageWrite and urEnqueueMemImageReady

[umf] Fix macOS build

065edc1

The AppleClang compiler emits warnings in C functions with zero arguments that are not specified as `f(void)`.

Merge pull request oneapi-src#853 from kbenzie/benie/fix-macos-build

172bc24

[umf] Fix macOS build

Create layered image properties struct.

017c998

Add initial CUDA and HIP usage guides

8edc7e2

omarahmed1111 force-pushed the merge-some-main-changes-into-adapters-second-patch branch from fbc0821 to a66476e Compare November 8, 2023 10:47

Merge branch 'adapters' into revert-1015-revert-1005-merge-some-main-…

7ba8fec

…changes-into-adapters

EwanC approved these changes Nov 8, 2023

View reviewed changes

isaacault approved these changes Nov 9, 2023

View reviewed changes

fabiomestre reviewed Nov 9, 2023

View reviewed changes

source/adapters/cuda/common.cpp Outdated Show resolved Hide resolved

omarahmed1111 added 2 commits November 10, 2023 17:06

Merge commit 'b12b606c35bb7469c1dfdf932e2917238635f02d' into merge-so…

7c7bf22

…me-main-changes-into-adapters-second-patch

Fix some merge problems

07ad4f8

omarahmed1111 force-pushed the merge-some-main-changes-into-adapters-second-patch branch from a66476e to 07ad4f8 Compare November 10, 2023 17:14

Merge branch 'adapters' into merge-some-main-changes-into-adapters-se…

65bfeab

…cond-patch

omarahmed1111 force-pushed the merge-some-main-changes-into-adapters-second-patch branch 7 times, most recently from 19e8d43 to 863d230 Compare November 10, 2023 22:22

Seanst98 requested changes Nov 13, 2023

View reviewed changes

Seanst98 approved these changes Nov 13, 2023

View reviewed changes

omarahmed1111 mentioned this pull request Nov 13, 2023

Merge main into adapters branch #1072

Merged

kbenzie mentioned this pull request Nov 14, 2023

[UR][L0] Add support for passing device list to urProgramBuild/Link/Compile #934

Merged

fabiomestre approved these changes Nov 14, 2023

View reviewed changes

omarahmed1111 force-pushed the merge-some-main-changes-into-adapters-second-patch branch from 863d230 to 898321c Compare November 14, 2023 21:15

omarahmed1111 added 2 commits November 14, 2023 21:54

Add more merge fixes

d86aada

Merge branch 'adapters' into merge-some-main-changes-into-adapters-se…

dad6534

…cond-patch

omarahmed1111 force-pushed the merge-some-main-changes-into-adapters-second-patch branch from 898321c to dad6534 Compare November 14, 2023 22:05

omarahmed1111 requested a review from a team as a code owner November 14, 2023 22:05

omarahmed1111 closed this Nov 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Second patch of bumping adapters branch #1014

Second patch of bumping adapters branch #1014

omarahmed1111 commented Oct 30, 2023 •

edited

Loading

EwanC left a comment

isaacault left a comment

Seanst98 left a comment

kbenzie commented Nov 13, 2023

Seanst98 commented Nov 13, 2023

omarahmed1111 commented Nov 16, 2023

Second patch of bumping adapters branch #1014

Second patch of bumping adapters branch #1014

Conversation

omarahmed1111 commented Oct 30, 2023 • edited Loading

EwanC left a comment

Choose a reason for hiding this comment

isaacault left a comment

Choose a reason for hiding this comment

Seanst98 left a comment

Choose a reason for hiding this comment

kbenzie commented Nov 13, 2023

Seanst98 commented Nov 13, 2023

omarahmed1111 commented Nov 16, 2023

omarahmed1111 commented Oct 30, 2023 •

edited

Loading