Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Add utility function ur_unreachable to simplify code #1124

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

wenju-he
Copy link
Contributor

No description provided.

@wenju-he wenju-he requested review from a team as code owners November 25, 2023 04:34
@wenju-he
Copy link
Contributor Author

wenju-he commented Nov 25, 2023

@kbenzie could you please take a look if this PR makes sense?
std::unreachable is only available in c++ 23.

Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU LGTM, thank you

source/common/ur_util.hpp Outdated Show resolved Hide resolved
@kbenzie
Copy link
Contributor

kbenzie commented Nov 27, 2023

I think there's a missing include in the CUDA file that's attempting to use ur::unreachable.

@wenju-he
Copy link
Contributor Author

wenju-he commented Nov 28, 2023

I think there's a missing include in the CUDA file that's attempting to use ur::unreachable.

added to both cuda/usm.cpp and hip/usm.cpp. I don't have access to cuda/hip machines to verify. After searching the headers used in hip/usm.cpp, it looks like ur_util.hpp is needed.

@kbenzie
Copy link
Contributor

kbenzie commented Nov 28, 2023

I think there's a missing include in the CUDA file that's attempting to use ur::unreachable.

added to both cuda/usm.cpp and hip/usm.cpp. I don't have access to cuda/hip machines to verify. After searching the headers used in hip/usm.cpp, it looks like ur_util.hpp is needed.

If you could add those includes we can let the CI check if the fix works.

Edit: I missed the commit. Seems there still an issue, I can look into this to see what's gone wrong.

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Nov 30, 2023
@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:46
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@pbalcer pbalcer merged commit 178e3fc into oneapi-src:main Jan 16, 2024
51 checks passed
@wenju-he wenju-he deleted the adapters-ur_unreachable branch March 5, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants