[L0] Maintain Lock of Queue while syncing the Last Command Event and update Last Command Event only if matching #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Jun 12, 2024
nrspruit
commented
- To avoid usecases where the LastcommandEvent could be updated in another thread and a thread can be expecting the Queue Wait to include this event, then hold the queue lock such that the last command event remains unchanged during synchronization.
- To avoid usecases where the LastcommandEvent could be updated in another thread and a thread can be expecting the Queue Wait to include this event, then hold the queue lock such that the last command event remains unchanged during synchronization. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jun 12, 2024
pre-commit PR for oneapi-src/unified-runtime#1749 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jun 12, 2024
pre-commit PR for oneapi-src/unified-runtime#1749 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jun 12, 2024
pre-commit PR for oneapi-src/unified-runtime#1749 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
pbalcer
reviewed
Jun 13, 2024
nrspruit
changed the title
nrspruit
force-pushed
the
fix_NonBlocking_LastCommand
branch
from
5df64a3
to
44370e3
Compare
pbalcer
approved these changes
Jun 13, 2024
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jun 13, 2024
…and update Last Command Event only if matching pre-commit PR for oneapi-src/unified-runtime#1749 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
fix_NonBlocking_LastCommand
branch
from
44370e3
to
a461778
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jun 13, 2024
…and update Last Command Event only if matching pre-commit PR for oneapi-src/unified-runtime#1749 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jun 13, 2024
…and update Last Command Event only if matching pre-commit PR for oneapi-src/unified-runtime#1749 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
kbenzie
added a commit
that referenced
this pull request
Jun 14, 2024
[L0] Maintain Lock of Queue while syncing the Last Command Event and update Last Command Event only if matching
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Jun 14, 2024
…14150) pre-commit PR for oneapi-src/unified-runtime#1749 --------- Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.