Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Loader] Suppress system errors when loading adapters on Windows #2060

Merged

Conversation

martygrant
Copy link
Contributor

@martygrant martygrant commented Sep 5, 2024

@aarongreig

Disables system errors when loading adapters on Windows, and re-enables them after.

intel/llvm#15388

@github-actions github-actions bot added the loader Loader related feature/bug label Sep 5, 2024
@martygrant martygrant force-pushed the martin/supressSystemErrorsOnWindows branch from 106fa9a to 4db3c1f Compare September 9, 2024 11:00
source/loader/ur_loader.cpp Outdated Show resolved Hide resolved
source/loader/ur_loader.cpp Outdated Show resolved Hide resolved
@martygrant martygrant marked this pull request as ready for review September 11, 2024 10:53
@martygrant martygrant requested a review from a team as a code owner September 11, 2024 10:53
@nrspruit nrspruit added the v0.10.x Include in the v0.10.x release label Sep 11, 2024
@martygrant martygrant force-pushed the martin/supressSystemErrorsOnWindows branch from 34ec5a4 to d7ac3dd Compare September 13, 2024 13:38
Co-authored-by: aarongreig <aaron.greig@codeplay.com>
@martygrant martygrant changed the title [Loader] Supress system errors when loading adapters on Windows [Loader] Suppress system errors when loading adapters on Windows Sep 13, 2024
@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Sep 16, 2024
@omarahmed1111 omarahmed1111 merged commit ad43e28 into oneapi-src:main Sep 16, 2024
71 of 74 checks passed
omarahmed1111 added a commit to omarahmed1111/unified-runtime that referenced this pull request Sep 16, 2024
…emErrorsOnWindows

[Loader] Suppress system errors when loading adapters on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Loader related feature/bug ready to merge Added to PR's which are ready to merge v0.10.x Include in the v0.10.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants