Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search support #23

Closed
onelson opened this issue Feb 13, 2021 · 0 comments · Fixed by #25
Closed

Search support #23

onelson opened this issue Feb 13, 2021 · 0 comments · Fixed by #25
Assignees
@onelson

Comments

@onelson
Copy link
Owner

onelson commented Feb 13, 2021

Part of the spec for alternate registries includes a search endpoint. Once built, it should be possible to offer a search UI in the frontend that uses this endpoint.

The actual implementation of the search index can be naive for this. We might be able to offer better matching with better performance once we adopt some kind of database to record package details. I think sqlite and postgres both offer extensions for full-text searching. For now, just do some clumsy substring matching on the package names.
@onelson onelson mentioned this issue Feb 13, 2021
Open
@onelson onelson self-assigned this Feb 14, 2021
onelson added a commit that referenced this issue Feb 15, 2021
@onelson
Add search endpoint.
8c69eb8 
This implements the `GET /api/v1/crates` which allows `cargo search` to
work.

This search implementation is very naive, and will be improved once we
have a database in place as our primary source for package info. In the
future the file system and git log will no longer be needed to respond
to requests like this, but for now these are the primary sources.

Fixes #23.
@onelson onelson mentioned this issue Feb 15, 2021
Merged
onelson added a commit that referenced this issue Feb 15, 2021
@onelson
Add search endpoint.
ac22ad1 
This implements the `GET /api/v1/crates` which allows `cargo search` to
work.

This search implementation is very naive, and will be improved once we
have a database in place as our primary source for package info. In the
future the file system and git log will no longer be needed to respond
to requests like this, but for now these are the primary sources.

Fixes #23.
onelson added a commit that referenced this issue Feb 15, 2021
@onelson
Add search endpoint.
9596bda 
This implements the `GET /api/v1/crates` which allows `cargo search` to
work.

This search implementation is very naive, and will be improved once we
have a database in place as our primary source for package info. In the
future the file system and git log will no longer be needed to respond
to requests like this, but for now these are the primary sources.

Fixes #23.
onelson added a commit that referenced this issue Feb 15, 2021
@onelson
Add search endpoint.
8c8df81 
This implements the `GET /api/v1/crates` which allows `cargo search` to
work.

This search implementation is very naive, and will be improved once we
have a database in place as our primary source for package info. In the
future the file system and git log will no longer be needed to respond
to requests like this, but for now these are the primary sources.

Fixes #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onelson onelson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add search endpoint. onelson/estuary
1 participant
@onelson