Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Cadence to secure-cadence-m8 #2499

Merged
merged 3 commits into from
May 27, 2022
Merged

Upgrade Cadence to secure-cadence-m8 #2499

merged 3 commits into from
May 27, 2022

Conversation

janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented May 26, 2022 •
edited
Loading

A simple bump in cadence version to secure-cadence-m8

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022 •
edited
Loading

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit d53b101

The command (for i in {1..N}; do go test ./fvm --bench . --tags relic -shuffle=on; done) was used.

Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
RuntimeTransaction/reference_tx-238.8ms ± 0%44.2ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/convert_int_to_string-240.3ms ± 0%43.2ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-245.4ms ± 0%42.0ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_signer_address-240.2ms ± 0%37.1ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_public_account-242.5ms ± 0%42.2ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_account_and_get_balance-2735ms ± 0%715ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_account_and_get_available_balance-2647ms ± 0%568ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_account_and_get_storage_used-251.4ms ± 0%52.9ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_account_and_get_storage_capacity-2564ms ± 0%573ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_signer_vault-253.6ms ± 0%53.4ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/get_signer_receiver-265.4ms ± 0%69.9ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/transfer_tokens-2253ms ± 0%275ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-246.6ms ± 0%48.7ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/load_and_save_long_string_on_signers_address-297.9ms ± 0%101.0ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/create_new_account-21.47s ± 0%1.50s ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/call_empty_contract_function-244.9ms ± 0%47.7ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/emit_event-262.3ms ± 0%66.9ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/borrow_array_from_storage-2156ms ± 0%160ms ± 0%~(p=1.000 n=1+1)
RuntimeTransaction/copy_array_from_storage-2154ms ± 0%155ms ± 0%~(p=1.000 n=1+1)
 
computationdelta
RuntimeTransaction/reference_tx-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2502 ± 0%502 ± 0%~(all equal)
RuntimeTransaction/get_signer_address-2302 ± 0%302 ± 0%~(all equal)
RuntimeTransaction/get_public_account-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-2802 ± 0%802 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-22.40k ± 0%2.40k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-21.10k ± 0%1.10k ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-23.50k ± 0%3.50k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/create_new_account-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/emit_event-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
RuntimeTransaction/copy_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
 
interactionsdelta
RuntimeTransaction/reference_tx-246.7k ± 0%46.7k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-246.7k ± 0%46.7k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-246.7k ± 0%46.7k ± 0%~(all equal)
RuntimeTransaction/get_signer_address-246.7k ± 0%46.7k ± 0%~(all equal)
RuntimeTransaction/get_public_account-246.7k ± 0%46.7k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-216.8M ± 0%16.8M ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-25.33M ± 0%5.33M ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-249.5k ± 0%49.5k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-25.32M ± 0%5.32M ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-248.0k ± 0%48.0k ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-248.4k ± 0%48.4k ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-249.1k ± 0%49.1k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-250.2k ± 0%50.2k ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-255.2k ± 0%55.2k ± 0%~(all equal)
RuntimeTransaction/create_new_account-28.47M ± 0%8.47M ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-246.9k ± 0%46.9k ± 0%~(all equal)
RuntimeTransaction/emit_event-246.9k ± 0%46.9k ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-253.1k ± 0%53.1k ± 0%~(all equal)
RuntimeTransaction/copy_array_from_storage-253.1k ± 0%53.1k ± 0%~(all equal)
 

sideninja
sideninja approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janezpodhostnik
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request May 27, 2022
@bors @janezpodhostnik
Merge #2499
14fa1d3 
2499: Upgrade Cadence to secure-cadence-m8 r=janezpodhostnik a=janezpodhostnik

A simple bump in cadence version to [secure-cadence-m8](https://github.com/onflow/cadence/releases/tag/secure-cadence-m8)

Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 27, 2022

Build failed:

janezpodhostnik
janezpodhostnik commented May 27, 2022
View reviewed changes
fvm/fvm_test.go Outdated Show resolved Hide resolved
@janezpodhostnik
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 27, 2022

Build succeeded:

@bors bors bot merged commit e50ac5f into master May 27, 2022
@bors bors bot deleted the janez/update-secure-cadence-m8 branch May 27, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@sideninja sideninja sideninja approved these changes

@turbolent turbolent Awaiting requested review from turbolent

@ramtinms ramtinms Awaiting requested review from ramtinms ramtinms is a code owner

@j1010001 j1010001 Awaiting requested review from j1010001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janezpodhostnik @SupunS @sideninja