Handle event encoding error gracefully (Port of 2562) #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 56d7658 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2565 +/- ##
==========================================
- Coverage 55.59% 52.29% -3.31%
==========================================
Files 757 555 -202
Lines 69971 51648 -18323
==========================================
- Hits 38899 27008 -11891
+ Misses 27881 22422 -5459
+ Partials 3191 2218 -973
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ramtinms
approved these changes
Jun 23, 2022
janezpodhostnik
approved these changes
Jun 27, 2022
|
bors merge |
|
Build failed: |
# Conflicts: # fvm/transactionEnv.go
# Conflicts: # fvm/transactionEnv.go
|
bors merge |
|
Build failed: |
# Conflicts: # engine/execution/computation/computer/computer_test.go # fvm/errors/codes.go # fvm/errors/failures.go # fvm/handler/event.go # fvm/transactionEnv.go # fvm/transactionInvoker.go
Fix other tests
m4ksio
changed the title
pattyshack
reviewed
Oct 19, 2022
| } | ||
| } | ||
|
|
||
| func (e *CadenceEventEncoder) Encode(event cadence.Event) ([]byte, error) { |
There was a problem hiding this comment.
just call return jsoncdc.Encode(event) here? Since you end up resetting the buffer / copying the payload on each Encode call, there no benefit in pre-allocating a buffer / encoder.
There was a problem hiding this comment.
Reusing the buffer should give some speedeup, as resetting keeps underlaying bytes, but this seemed to be rather insignificant. So I did a benchmark and looks like there is quite a difference.
BenchmarkEncodingBuffer-16 1306316 949.6 ns/op
BenchmarkEncodingBuffer-16 1230076 944.8 ns/op
BenchmarkEncodingBuffer-16 1282364 941.2 ns/op
BenchmarkEncodingBuffer-16 1311118 900.7 ns/op
BenchmarkEncodingBufferV2-16 1468462 807.6 ns/op
BenchmarkEncodingBufferV2-16 1501274 821.0 ns/op
BenchmarkEncodingBufferV2-16 1456159 812.9 ns/op
BenchmarkEncodingBufferV2-16 1464187 818.2 ns/op
BenchmarkEncodingBufferV2-16 1410309 829.4 ns/op
PASS
ok github.com/onflow/flow-go/fvm/environment 20.927
V2 is the new version. I think difference would be even more visible for larger events.
pattyshack
approved these changes
Oct 19, 2022
|
Closes #2563 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this was a simple port, but it was unmerged for too long and I had to start from scratch.
I