fix storage #3064
Merged
fix storage #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3064 +/- ##
==========================================
+ Coverage 55.26% 55.27% +0.01%
==========================================
Files 760 760
Lines 69716 69718 +2
==========================================
+ Hits 38526 38536 +10
+ Misses 28024 28017 -7
+ Partials 3166 3165 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
koko1123
approved these changes
Aug 23, 2022
|
@smnzhu can you add some context to the description on what this change is fixing? |
peterargue
approved these changes
Oct 19, 2022
|
bors merge |
|
Build failed: |
|
@smnzhu Looks like there are some legit unit test failures |
Kay-Zee
requested review from
ramtinms,
janezpodhostnik,
pattyshack,
yhassanzadeh13 and
m4ksio
as code owners
peterargue
approved these changes
Nov 25, 2022
| trackerStorage := mocktracker.NewMockStorage() | ||
|
|
||
| // Assume SetFulfilledHeight succeeds unless otherwise indicadted in a test requriement | ||
| trackerStorage.On("SetFulfilledHeight", mock.Anything).Return(nil) |
There was a problem hiding this comment.
this line is also run in mocktracker.NewMockStorage() so you can probably skip it here
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 02e9bc3 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
janezpodhostnik
approved these changes
Nov 28, 2022
pattyshack
approved these changes
Nov 28, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
3064: fix storage r=Kay-Zee a=smnzhu Updates the execution data provider to track fulfilled height. 3596: [Metrics] Report finalized height and executed height on startup r=zhangchiqing a=zhangchiqing This PR fixes an issue that the finalized height and executed height metrics is not reported on startup until there is block being finalized and executed. For EN which takes a while to load the execution state, the finalized height and executed height is not shown on metrics. This PR fixes it by reporting finalized height and executed height on startup. Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com> Co-authored-by: Kan Zhang <kan@axiomzen.co> Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com> Co-authored-by: Kay-Zee <kan@axiomzen.co> Co-authored-by: Leo Zhang (zhangchiqing) <zhangchiqing@gmail.com> Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
3064: fix storage r=Kay-Zee a=smnzhu Updates the execution data provider to track fulfilled height. Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com> Co-authored-by: Kan Zhang <kan@axiomzen.co> Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com> Co-authored-by: Kay-Zee <kan@axiomzen.co>
Kay-Zee
force-pushed
the
smnzhu/storage-fix
branch
from
7d891b2
to
b3bb757
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the execution data provider to track fulfilled height.