Update HotStuff Reader CLI Tool #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/active-pacemaker #3363 +/- ##
============================================================
- Coverage 55.30% 55.28% -0.03%
============================================================
Files 748 748
Lines 69412 69412
============================================================
- Hits 38387 38372 -15
- Misses 27890 27901 +11
- Partials 3135 3139 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zhangchiqing
approved these changes
Oct 11, 2022
durkmurder
approved these changes
Oct 14, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 18, 2022
3363: Update HotStuff Reader CLI Tool r=jordanschalm a=jordanschalm This PR modifies the HotStuff CLI command, replacing `get-view` with `get-liveness` and `get-safety`. Example usage on Localnet: <img width="400" alt="Screen Shot 2022-10-10 at 12 36 57 PM" src="https://user-images.githubusercontent.com/10557821/194847963-558aeb87-fed2-4694-a550-5f300e0036f1.png"> <img width="400" alt="Screen Shot 2022-10-10 at 12 29 46 PM" src="https://user-images.githubusercontent.com/10557821/194848032-9bbf6fca-e1ad-41f1-aa1d-b05cb46938a3.png"> <img width="400" alt="Screen Shot 2022-10-10 at 12 28 36 PM" src="https://user-images.githubusercontent.com/10557821/194848080-f5db1505-f304-4865-8952-236cb6a71089.png"> Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
|
Build failed: |
|
I think the failing consensus tests here would be fixed by the addition of a block message queue to |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the HotStuff CLI command, replacing
get-viewwithget-livenessandget-safety.Example usage on Localnet: