Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] Log fees error #3392

Merged
merged 1 commit into from
Oct 18, 2022
Merged

[FVM] Log fees error #3392

merged 1 commit into from
Oct 18, 2022

Conversation

janezpodhostnik
Copy link
Contributor

Just an additional error to log if fee deduction fails.

@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 0f23f96

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
ComputeBlock/16/cols/128/txes-26.83s ± 0%6.69s ± 0%~(p=1.000 n=1+1)
 
us/txdelta
ComputeBlock/16/cols/128/txes-23.33k ± 0%3.27k ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
ComputeBlock/16/cols/128/txes-21.27GB ± 0%1.28GB ± 0%~(p=1.000 n=1+1)
 
allocs/opdelta
ComputeBlock/16/cols/128/txes-219.8M ± 0%19.8M ± 0%~(p=1.000 n=1+1)
 

@janezpodhostnik
Copy link
Contributor Author

bors merge

@bors bors bot merged commit 7c4dc9d into master Oct 18, 2022
@bors bors bot deleted the janez/log-fees-error branch October 18, 2022 13:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants