[Execution] remove duplicate blobservice on execution nodes #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tonix517
approved these changes
Oct 19, 2022
m4ksio
approved these changes
Oct 19, 2022
|
bors merge |
peterargue
added a commit
that referenced
this pull request
Oct 19, 2022
vishalchangrani
pushed a commit
that referenced
this pull request
Oct 19, 2022
* Merge #3418 3418: [Execution] remove duplicate blobservice on execution nodes r=peterargue a=peterargue Execution nodes only need a single blob service Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com> * Merge #3407 3407: Align request handlers between common and collection sync engines r=peterargue a=peterargue Align message processing between common and collection sync engines Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com> * Merge #3375 3375: [BFT] Improve network message validation r=peterargue a=peterargue Improve handling for several network message fields: * Explicitly validate `msg.ChannelID` matches the `Topic` for pubsub messages * Generate the `msg.EventID` and `msg.Type` Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution nodes only need a single blob service